WIP Again (continued)

This forum is for making announcements about updated cheat files (for any emulator), updated web pages and of course about improvements to the MAME/MESS cheat engine.
User avatar
ianpatt
Posts: 336
Joined: Sat Sep 22, 2001 1:00 am
Location: San Francisco, CA

WIP Again (continued)

Post by ianpatt »

The previous thread was getting big, so I thought I'd start a new one.

All bugfixes/features since last update added. I'm going to be away from the computer again for one day or so.

New source/binary:
source
binary
sum
Posts: 153
Joined: Wed Sep 26, 2001 1:00 am
Location: Hong Kong
Contact:

Post by sum »

Updated Mame32 binary
commented out winalloc.o in src/windows/windows.mak[/url]
User avatar
Pugsy
Posts: 3638
Joined: Fri Aug 17, 2001 12:59 am
Location: North Wales, UK.
Has thanked: 1 time
Been thanked: 12 times
Contact:

Some more bugs..

Post by Pugsy »

Just a couple of quickies that I've just spotted. Tested with the game daraku.

1. If you do a new TIMER cheat search with anything other than 00 in the LIVES value you will get 0 results returned. Even although it's a new TIMER search!

2. ESC and TAB don't go back a menu on Timer & Lives searches (new and continued) you have to select one of the other options then the keys do what they should. [It may do it on other menus but I've not encountered it yet]


And a request, any chance you could change the way the small results/message windows work. At the moment the time they appear is linked to the game...however if the game is particularly slow or you've got the game paused they will seem to appear for ever. Can you make it so that all active results/message windows disappear when you navigate back a menu (either by the menu option or via TAB or ESCAPE).

Keep up the good work 8)
Pugsy

Servicing your cheating needs since 1985 8)

Grab the latest cheat collection:
MAME 0.259 XML cheat collection (6 OCTOBER 2023) from http://www.mamecheat.co.uk or direct from:-
https://mega.nz/file/q4dHGZ6K#i-EUiqIjH ... KMz7hnbTfw (ZIP Archive 3.76MB)
User avatar
Pugsy
Posts: 3638
Joined: Fri Aug 17, 2001 12:59 am
Location: North Wales, UK.
Has thanked: 1 time
Been thanked: 12 times
Contact:

Advanced search dialogue

Post by Pugsy »

Can you change the order of the menu in the Advanced Search Dialogue to make it easier to understand from the off.

Current Order:-

Code: Select all

Value
LHS
RHS
Comparison
Suggested Order:-

Code: Select all

LHS
Comparison
RHS
Value
Also I think it may be better to lose the 'LHS' & 'Comparison' & 'RHS' text displayed. Just having the fields alone (centred) would be explanation enough I feel, having RHS & LHS when the comparison is displayed vertically rather than horizontally isn't really necessary. Perhaps add the search dialogue without these fieldnames as:-

Code: Select all

_command:00000003
Pugsy

Servicing your cheating needs since 1985 8)

Grab the latest cheat collection:
MAME 0.259 XML cheat collection (6 OCTOBER 2023) from http://www.mamecheat.co.uk or direct from:-
https://mega.nz/file/q4dHGZ6K#i-EUiqIjH ... KMz7hnbTfw (ZIP Archive 3.76MB)
kelvSYC
Posts: 1121
Joined: Thu Sep 27, 2001 1:00 am
Location: Calgary, AB, Canada

Post by kelvSYC »

I can't ESC out of the search menus when the cursor is on Timer or Lives (both old-style) either. Also to note that neither the activation key bug in Mac OS nor the fact that editing a cheat in the second and subsequent games that you play in a session crashes MacMAME.
kelvSYC's Guide to the Cheat Engine - http://members.shaw.ca/kelvsyc/cheatguide.html

The New Move List Cheat Collection - http://mamecheat.co.uk/forums/viewtopic.php?p=6469

Underscore Command - What better game is there?
Tourniquet
Posts: 163
Joined: Wed Sep 19, 2001 1:00 am
Location: UK
Contact:

Post by Tourniquet »

Ian, rom cheats don't seem to undo the damage when you disable them ;(
User avatar
ianpatt
Posts: 336
Joined: Sat Sep 22, 2001 1:00 am
Location: San Francisco, CA

Re: Some more bugs..

Post by ianpatt »

Pugsy wrote:1. If you do a new TIMER cheat search with anything other than 00 in the LIVES value you will get 0 results returned. Even although it's a new TIMER search!
That's a user interface problem; it was working correctly, but I was showing the wrong message. It should say that results have been saved (like in the old engine.) Fixed.
Pugsy wrote:2. ESC and TAB don't go back a menu on Timer & Lives searches (new and continued) you have to select one of the other options then the keys do what they should. [It may do it on other menus but I've not encountered it yet]
Fixed.
Pugsy wrote:And a request, any chance you could change the way the small results/message windows work. At the moment the time they appear is linked to the game...however if the game is particularly slow or you've got the game paused they will seem to appear for ever. Can you make it so that all active results/message windows disappear when you navigate back a menu (either by the menu option or via TAB or ESCAPE).
This will take a patch to usrintrf.c, but it's possible. I'll do this before submitting it, but not right now. (usrintrf.c in the version of MAME I do all development with is modified heavily already, will need to test with a clean copy)
User avatar
ianpatt
Posts: 336
Joined: Sat Sep 22, 2001 1:00 am
Location: San Francisco, CA

Re: Advanced search dialogue

Post by ianpatt »

Pugsy wrote:Can you change the order of the menu in the Advanced Search Dialogue to make it easier to understand from the off.
Added.
Pugsy wrote:Also I think it may be better to lose the 'LHS' & 'Comparison' & 'RHS' text displayed. Just having the fields alone (centred) would be explanation enough I feel, having RHS & LHS when the comparison is displayed vertically rather than horizontally isn't really necessary. Perhaps add the search dialogue without these fieldnames as:-

Code: Select all

_command:00000003
Added. Either add the command line or use the options menu. I'll need to use this for a bit to see if I want it to be the default or not. Seems like a good idea so far, though.
User avatar
ianpatt
Posts: 336
Joined: Sat Sep 22, 2001 1:00 am
Location: San Francisco, CA

Post by ianpatt »

kelvSYC wrote:Also to note that neither the activation key bug in Mac OS nor the fact that editing a cheat in the second and subsequent games that you play in a session crashes MacMAME.
Do you mean "neither x nor y happen any more" or "neither x nor y have been fixed?"

edit: tested the current code in MacMAME - no problems. Of course, this may be because my compile of MacMAME is over five versions old...
Last edited by ianpatt on Wed Apr 03, 2002 8:23 am, edited 1 time in total.
User avatar
ianpatt
Posts: 336
Joined: Sat Sep 22, 2001 1:00 am
Location: San Francisco, CA

Post by ianpatt »

Tourniquet wrote:Ian, rom cheats don't seem to undo the damage when you disable them ;(
Fixed. I made the "restore previous value" bit work. Just set the bit and the previous value will be restored when the cheat is deactivated. Updated old cheat conversion table to support this.

Note: this bit is not automatically set for all ROM cheats; you must set it yourself. The upside is that it can be applied to all types of cheats.
User avatar
ianpatt
Posts: 336
Joined: Sat Sep 22, 2001 1:00 am
Location: San Francisco, CA

updates and stuff

Post by ianpatt »

Uploaded fixes. Included MAME32 binary because I'm feeling nice.

I'm also sending .map files along with the binaries; please put them in the same folder as the MAME executable. If you change the name of the executable, please also change the name of the .map file. These files enhance the debugging capabilities built in to MAME by adding a useful stack trace showing where a crash occured.

So, when reporting a crash bug (if there are any) please include the extra stuff printed/logged (wherever stderr goes) when MAME quits.

New source/binary:
source
binary
mame32 binary
User avatar
Pugsy
Posts: 3638
Joined: Fri Aug 17, 2001 12:59 am
Location: North Wales, UK.
Has thanked: 1 time
Been thanked: 12 times
Contact:

Post by Pugsy »

THanks for the fixes, downloading the source now :D

Oh one thing I forgot to mention, a large number of continuous comment lines will not all display with either the arrows or page up/down. To see what I mean paste these cheats over the current cheat for the game apparel and you'll see that the lookup list doesn't display correctly:-

Code: Select all

; [ Apparel Night (Japan) ]
apparel:0:0000:00:999:[ The winning hand cheat must be      ]
apparel:0:0000:00:999:[ activated when there are 14 tiles   ]
apparel:0:0000:00:999:[ in your hand, then press the RON    ]
apparel:0:0000:00:999:[ key ('Z' by default). The tiles do  ]
apparel:0:0000:00:999:[ not visually change until you make  ]
apparel:0:0000:00:999:[ a move.                             ]
apparel:0:F406:31:001:Get winning hand Now!
apparel:0:F407:31:501:Get winning hand Now! (02/14)
apparel:0:F408:31:501:Get winning hand Now! (03/14)
apparel:0:F409:32:501:Get winning hand Now! (04/14)
apparel:0:F40A:32:501:Get winning hand Now! (05/14)
apparel:0:F40B:32:501:Get winning hand Now! (06/14)
apparel:0:F40C:33:501:Get winning hand Now! (07/14)
apparel:0:F40D:33:501:Get winning hand Now! (08/14)
apparel:0:F40E:33:501:Get winning hand Now! (09/14)
apparel:0:F40F:34:501:Get winning hand Now! (10/14)
apparel:0:F410:34:501:Get winning hand Now! (11/14)
apparel:0:F411:34:501:Get winning hand Now! (12/14)
apparel:0:F412:35:501:Get winning hand Now! (13/14)
apparel:0:F413:35:501:Get winning hand Now! (14/14)
apparel:0:F406:31:000:Always winning hand
apparel:0:F407:31:500:Always winning hand (02/14)
apparel:0:F408:31:500:Always winning hand (03/14)
apparel:0:F409:32:500:Always winning hand (04/14)
apparel:0:F40A:32:500:Always winning hand (05/14)
apparel:0:F40B:32:500:Always winning hand (06/14)
apparel:0:F40C:33:500:Always winning hand (07/14)
apparel:0:F40D:33:500:Always winning hand (08/14)
apparel:0:F40E:33:500:Always winning hand (09/14)
apparel:0:F40F:34:500:Always winning hand (10/14)
apparel:0:F410:34:500:Always winning hand (11/14)
apparel:0:F411:34:500:Always winning hand (12/14)
apparel:0:F412:35:500:Always winning hand (13/14)
apparel:0:F413:35:500:Always winning hand (14/14)
apparel:0:F406:00:998:Watch ALL 14 tiles - Player:You will have to manually edit the watch and change "Number of bytes" = 14
apparel:0:F486:00:998:Watch ALL 14 tiles - C.P.U.:You will have to manually edit the watch and change "Number of bytes" = 14
apparel:0:0000:00:999:[ Here is the look-up list for        ]
apparel:0:0000:00:999:[ the above watches.                  ]
apparel:0:0000:00:999:[                                     ]
apparel:0:0000:00:999:[ value  common name     chinese name ]
apparel:0:0000:00:999:[ 01h    1 "characters"  1 "wan"      ]
apparel:0:0000:00:999:[ 02h    2 "characters"  2 "wan"      ]
apparel:0:0000:00:999:[ 03h    3 "characters"  3 "wan"      ]
apparel:0:0000:00:999:[ 04h    4 "characters"  4 "wan"      ]
apparel:0:0000:00:999:[ 05h    5 "characters"  5 "wan"      ]
apparel:0:0000:00:999:[ 06h    6 "characters"  6 "wan"      ]
apparel:0:0000:00:999:[ 07h    7 "characters"  7 "wan"      ]
apparel:0:0000:00:999:[ 08h    8 "characters"  8 "wan"      ]
apparel:0:0000:00:999:[ 09h    9 "characters"  9 "wan"      ]
apparel:0:0000:00:999:[ 11h    1 "dots"        1 "tung"     ]
apparel:0:0000:00:999:[ 12h    2 "dots"        2 "tung"     ]
apparel:0:0000:00:999:[ 13h    3 "dots"        3 "tung"     ]
apparel:0:0000:00:999:[ 14h    4 "dots"        4 "tung"     ]
apparel:0:0000:00:999:[ 15h    5 "dots"        5 "tung"     ]
apparel:0:0000:00:999:[ 16h    6 "dots"        6 "tung"     ]
apparel:0:0000:00:999:[ 17h    7 "dots"        7 "tung"     ]
apparel:0:0000:00:999:[ 18h    8 "dots"        8 "tung"     ]
apparel:0:0000:00:999:[ 19h    9 "dots"        9 "tung"     ]
apparel:0:0000:00:999:[ 21h    1 "bamboo"      1"tiao/Bird" ]
apparel:0:0000:00:999:[ 22h    2 "bamboo"      2 "tiao"     ]
apparel:0:0000:00:999:[ 23h    3 "bamboo"      3 "tiao"     ]
apparel:0:0000:00:999:[ 24h    4 "bamboo"      4 "tiao"     ]
apparel:0:0000:00:999:[ 25h    5 "bamboo"      5 "tiao"     ]
apparel:0:0000:00:999:[ 26h    6 "bamboo"      6 "tiao"     ]
apparel:0:0000:00:999:[ 27h    7 "bamboo"      7 "tiao"     ]
apparel:0:0000:00:999:[ 28h    8 "bamboo"      8 "tiao"     ]
apparel:0:0000:00:999:[ 29h    9 "bamboo"      9 "tiao"     ]
apparel:0:0000:00:999:[ 31h    East  "wind"                 ]
apparel:0:0000:00:999:[ 32h    South "wind"                 ]
apparel:0:0000:00:999:[ 33h    West  "wind"                 ]
apparel:0:0000:00:999:[ 34h    North "wind"                 ]
apparel:0:0000:00:999:[ 35h    White "dragon"               ]
apparel:0:0000:00:999:[ 36h    Green "dragon"               ]
apparel:0:0000:00:999:[ 37h    Red   "dragon"               ]
apparel:0:0000:00:999:[ 3Fh    - no tile -                  ]

PS: Have you had a chance at looking at making the cheat engine utilise the MESS crc32s yet?
Pugsy

Servicing your cheating needs since 1985 8)

Grab the latest cheat collection:
MAME 0.259 XML cheat collection (6 OCTOBER 2023) from http://www.mamecheat.co.uk or direct from:-
https://mega.nz/file/q4dHGZ6K#i-EUiqIjH ... KMz7hnbTfw (ZIP Archive 3.76MB)
Tourniquet
Posts: 163
Joined: Wed Sep 19, 2001 1:00 am
Location: UK
Contact:

Post by Tourniquet »

I've got to go home and try the new code, but in the previous version there was a crash when I tried to delete a result from the results list by pressing 'd'. (They were bit, if it makes any difference).

Hitting 's' on a watch didn't save it, like the old ver.

The restore results didn't work for me?
User avatar
ianpatt
Posts: 336
Joined: Sat Sep 22, 2001 1:00 am
Location: San Francisco, CA

Post by ianpatt »

Tourniquet wrote:I've got to go home and try the new code, but in the previous version there was a crash when I tried to delete a result from the results list by pressing 'd'. (They were bit, if it makes any difference).
There was a large bug in a previous version causing crashes when deleting cheats which is fixed now. This is (hopefully) the problem. Just to be safe, I'll test this a bunch.
Tourniquet wrote:Hitting 's' on a watch didn't save it, like the old ver.
Now it does. In an ugly way, but it works.
Tourniquet wrote:The restore results didn't work for me?
Forgot to save/restore the number of results. Fixed.
User avatar
ianpatt
Posts: 336
Joined: Sat Sep 22, 2001 1:00 am
Location: San Francisco, CA

Post by ianpatt »

Pugsy wrote:Oh one thing I forgot to mention, a large number of continuous comment lines will not all display with either the arrows or page up/down. To see what I mean paste these cheats over the current cheat for the game apparel and you'll see that the lookup list doesn't display correctly
Fixed. Now scrolling will skip a maximum of one page size (or two for pageup/pagedown.)
PS: Have you had a chance at looking at making the cheat engine utilise the MESS crc32s yet?
No; procrastinating. I'll do it soon, really I will.

Where do I get the checksum from?
kelvSYC
Posts: 1121
Joined: Thu Sep 27, 2001 1:00 am
Location: Calgary, AB, Canada

Post by kelvSYC »

I meant the latter, but I'll have to check out the new source.
kelvSYC's Guide to the Cheat Engine - http://members.shaw.ca/kelvsyc/cheatguide.html

The New Move List Cheat Collection - http://mamecheat.co.uk/forums/viewtopic.php?p=6469

Underscore Command - What better game is there?
Bugfinder
Posts: 168
Joined: Tue Sep 25, 2001 1:00 am
Location: Rio de Janeiro, Brasil

Bugs, questions (quick edit)

Post by Bugfinder »

Bug 1: in classic mode I only get 0 results.

Bug 2: when selecting memory areas, if you go from Very Slow to All Memory, the arrows will be printed in the bottom of screen - you can see it when running a vertical game like 1942. Horizontal games will hide the arrows.

Question 1: can I delete a complete memory region when checking results or only individual addresses? The only way to do this is removing that memory region in the next search, right? In this case I'm forced to do another search, which might delete some important addresses. Do you think it's okay to have shift+ "d" to delete entire memory regions from results?

Question 2: Remember that hack I made to ddsom to fix a Capcom bug? I need a value "06" turning into "07" after XORed, or encrypted code "6D" turning into "6C" before XORing, or even turning the value in XOR table from 6B to 6A.

The XOR is in dd2ex.04d at position 4988A but when loaded it goes to C988B (adds 512 Kb and bite-swaps). The options are:

1) Poking in already XORed code (can't see this memory area - watches don't show regions)

2) Poking in encrypted code, must be before the core XORs
6D XOR 6B (value in XOR table, before) = 06
6C XOR 6B (value in XOR table, after) = 07 OK

3) Poking in XOR table, must be before the core XORs
6D XOR 6B (value in XOR table, before) = 06
6D XOR 6A (value in XOR table, after) = 07 OK

So if I want that poke automatically applied, how should I add it? I'd prefer option 1.

Filipe Estima
Bugfinder
------------------------------------------
If there's a bug, I'm gonna find it!
kelvSYC
Posts: 1121
Joined: Thu Sep 27, 2001 1:00 am
Location: Calgary, AB, Canada

Post by kelvSYC »

New bug: now the lives and timers (old style) searches only show either a zero or a one and no other values.

Also, if I start a new cheat search (through saving all values), and immediately continue (nothing's changed) with an equal search, the search returns zero results.
kelvSYC's Guide to the Cheat Engine - http://members.shaw.ca/kelvsyc/cheatguide.html

The New Move List Cheat Collection - http://mamecheat.co.uk/forums/viewtopic.php?p=6469

Underscore Command - What better game is there?
User avatar
ianpatt
Posts: 336
Joined: Sat Sep 22, 2001 1:00 am
Location: San Francisco, CA

Post by ianpatt »

kelvSYC wrote:New bug: now the lives and timers (old style) searches only show either a zero or a one and no other values.

Also, if I start a new cheat search (through saving all values), and immediately continue (nothing's changed) with an equal search, the search returns zero results.
Searching was broken last release. Fixed now.
User avatar
ianpatt
Posts: 336
Joined: Sat Sep 22, 2001 1:00 am
Location: San Francisco, CA

Re: Bugs, questions (quick edit)

Post by ianpatt »

Bugfinder wrote:Bug 1: in classic mode I only get 0 results.
Fixed. Last time I broke searching alltogether.
Bugfinder wrote:Bug 2: when selecting memory areas, if you go from Very Slow to All Memory, the arrows will be printed in the bottom of screen - you can see it when running a vertical game like 1942. Horizontal games will hide the arrows.
Fixed.
Bugfinder wrote:Question 1: can I delete a complete memory region when checking results or only individual addresses? The only way to do this is removing that memory region in the next search, right? In this case I'm forced to do another search, which might delete some important addresses. Do you think it's okay to have shift+ "d" to delete entire memory regions from results?
Added.
Bugfinder wrote:Question 2: Remember that hack I made to ddsom to fix a Capcom bug? I need a value "06" turning into "07" after XORed, or encrypted code "6D" turning into "6C" before XORing, or even turning the value in XOR table from 6B to 6A.
Method one is the best (and the only one that will work.)

This depends on whether the byte you're patching is accessed by a pc-relative read or not. If this data is pc-relative, then you need to write to REGION_USER1, otherwise write to REGION_CPU1.

To find the address, you need to find what address the CPU would use to read this data. This is because the the absolute address of a byte (for a system with a 16 or 32-bit data bus) is different depending on your computer's endianness.

In this case, since the CPU is 16 bit, and the MC68000 and x86 have differing byte orders, you need to XOR all byte reads with 1 to find the CPU address of a logical address. So, thie cheat would be:

Code: Select all

:ddsom:20000000:0C988A:00000007:00000000:Bug Fix
I think. I don't remember what this fixes, so I can't test it. In any case, all you should need to do is either change the address from 0xC988A -> 0xC988B, or change the memory region from REGION_CPU1 -> REGION_USER1.
Locked