Emulator Cheats

ShimaPong wrote:OK, I have finished checking for 3rd update.
http://zetubou.mine.nu/timer/file/bomber31853_d5.zip

* code loading:
- Ignored to load old format code by default. If you need to
load, choose "Load Old Format" item in Options menu.
But in the future, it should be merged into new format.

				/* ----- convert the old code to the new format ----- */
				if(TEST_FIELD(cheatOptions, LoadOldFormat))
					//type = ConvertOldCode(oldCode, oldCPU, &data, &extendData);
					continue;

Cheat Engine Commands:

These special cheat lines are used to set global preferences for the cheat engine. They follow this format:

:_command:[ data ]

The lower byte of the data field stores the command, and the remaining bytes store data for the command. Here is a list of the commands:

0x00 disable help boxes (once I add them)
0x01 use old-style cheat search box (now redundant)
0x02 use new-style cheat search box
0x03 don't print labels in new-style search menu
0x04 auto-save cheats on exit

So, if you wanted to use the old-style cheat box, you would add this line to your cheat.dat:

:_command:00000001

Stephh wrote:I'm not sure that cheat.txt will be added to official documentation files ... IMO, it should be best distributed with Pugsy's cheat.dat file ... What do you think about that ?

Stephh wrote:How does it work ? Which bit of the option field is it ? I have serious doubt with this code

Stephh wrote:BTW, in cheat.txt, the comments seem wrong

Stephh wrote:Last thing : please NEVER remove the possibility to still use the old format as I REALLY need it !

ShimaPong wrote:

Stephh wrote:How does it work ? Which bit of the option field is it ? I have serious doubt with this code

Sorry, the dust has remained. It's hard for me to figure out many modification completely in "BIG" file.
Remove "//" to work old format loading. Other fix will be unneeded.

Stephh wrote:Last thing : please NEVER remove the possibility to still use the old format as I REALLY need it !

Please give me an idea to manage current "BIG" cheat source file !

• Can't access in finalizr, roadf.
• Restore Previous Value doesn't work or even causes the game crash in rachero, goldnaxj.

• Added 3rd search menu, called "Minimum Search Mode".
• Added new operation, called "Write if Match".

could you please send me an update cheat.c file that fixes the bug and which is up-to-date ?

As for cheat.txt, the file will be distributed by Pugsy

Anyway, how many parts do you need ?

ShimaPong wrote:

could you please send me an update cheat.c file that fixes the bug and which is up-to-date ?

After arrangements are finalized.

But I don't use and understand old format so that if the cheat engine has a trouble, I may be unable to resolve an issue.

As for cheat.txt, the file will be distributed by Pugsy

Current database has the same material as cheat.txt. I think divide it from the database too because also the database is big.

Anyway, how many parts do you need ?

Main problem is that I don't know how to divide source file because it needs to fix other files which is not associated with cheat core directly.
So I hope you to do if you will.

ShimaPong wrote:Now stop updating and checking the cheat engine ...

Stephh wrote:so I can have a look before I go on holidays ...

ShimaPong wrote:

Stephh wrote:so I can have a look before I go on holidays ...

Sorry... I make an effort before you go on holidays though I don't know when you go.

ShimaPong wrote:3rd Update Plus.
http://zetubou.mine.nu/timer/file/bomber32453_d5.zip

			case kMenu_LoadOldFormat:
				if(TEST_FIELD(cheatOptions, Debug))
					TOGGLE_MASK_FIELD(cheatOptions, LoadOldFormat);
				break;

			case kMenu_LoadOldFormat:
				if(TEST_FIELD(cheatOptions, LoadOldFormat))
					TOGGLE_MASK_FIELD(cheatOptions, LoadOldFormat);
				break;
			case kMenu_Debug:
				if(TEST_FIELD(cheatOptions, Debug))
					TOGGLE_MASK_FIELD(cheatOptions, Debug);
				break;

Stephh wrote:If you agree with this, I change the cheat.c file, then I submit it to MAME Team

ShimaPong wrote:Sorry, it's not bug. I have forgotten to explain it.
Debug option is for cheat engine developer so that I intend to forbid changing by end-user easily.
Developer needs to edit command code directly on the text editor and can confirm debug ON/OFF on the Options menu.
I made that point before, and I can't manage old format so that "Load Old Format" is one of Debug items.
But if you feel troublesome, fix with your idea and send.

			case kMenu_LoadOldFormat:
					TOGGLE_MASK_FIELD(cheatOptions, LoadOldFormat);
				break;
			case kMenu_Debug:
					TOGGLE_MASK_FIELD(cheatOptions, Debug);
				break;

Stephh wrote:The most important thing is that the (classic ?) search function seems to be broken somewhere : I can't even not find lives for a game such as 'bonzeadv' as the result is always 0 when I "continue" search ! Isn't there a problem with the "backup" data ?

Stephh wrote:The "load old format" option doesn't seem to work correctly as the old cheats now seem to be always loaded ... It's a good news that old format is still supported, but the option should do something ...

Stephh wrote:Once all this is fixed, I'll ask you to stop further development on this file (what else do you need anyway ?) as the cheat.c file needs special work and a huge rewrite, not to add new stuff, but to have a source file which is "compatible" with all the other ones in MAME ...

ShimaPong wrote:

Stephh wrote:The most important thing is that the (classic ?) search function seems to be broken somewhere : I can't even not find lives for a game such as 'bonzeadv' as the result is always 0 when I "continue" search ! Isn't there a problem with the "backup" data ?

I don't understand why you say, "search function seems to be broken".
Because the search function works on my MAME 0.111u2.
Please more report.

ShimaPong wrote:

Stephh wrote:The most important thing is that the (classic ?) search function seems to be broken somewhere : I can't even not find lives for a game such as 'bonzeadv' as the result is always 0 when I "continue" search ! Isn't there a problem with the "backup" data ?

I don't understand why you say, "search function seems to be broken".
Because the search function works on my MAME 0.111u2.
Please more report.

diff -Nru old/cheat.c src/cheat.c
--- old/cheat.c	2007-01-06 12:06:56.000000000 +0100
+++ src/cheat.c	2007-01-09 17:58:12.000000000 +0100
@@ -5668,8 +5668,9 @@
 
 	if(doSearch)
 	{
-		/* ----- initialize search ----- */
-		InitializeNewSearch(search);
+		if(!doneSaveMemory)
+			/* ----- initialize search ----- */
+			InitializeNewSearch(search);
 
 		if( (sel == kMenu_ValueEqual) || (sel == kMenu_ValueNearTo) || doneSaveMemory)
 		{
@@ -6117,8 +6118,9 @@
 					break;
 
 				case kMenu_DoSearch:
-					/* ----- initialize search ----- */
-					InitializeNewSearch(search);
+					if(!doneMemorySave)
+						/* ----- initialize search ----- */
+						InitializeNewSearch(search);
 
 					if((!kSearchOperandNeedsInit[search->lhs] && !kSearchOperandNeedsInit[search->rhs]) || doneMemorySave)
 					{

Stephh wrote:The "load old format" option doesn't seem to work correctly as the old cheats now seem to be always loaded ... It's a good news that old format is still supported, but the option should do something ...

Also I don't know why the cheat engine doesn't load old format.
Over and over again I say, I don't use and can't understand old format so that I don't know the cause.

Stephh wrote:Once all this is fixed, I'll ask you to stop further development on this file (what else do you need anyway ?) as the cheat.c file needs special work and a huge rewrite, not to add new stuff, but to have a source file which is "compatible" with all the other ones in MAME ...

...? Please more easy English.

Stephh wrote: found the bug that affects the "classic" and "advanced" search ("minimum" was working correctly) : you ALWAYS initialised the search, thus the 0 results ...

Stephh wrote:The cheat.c file has to be rewritten to use the same "conventions" as the other files