[kof98] The King of Fighters '98: The Slugfest

[nolberto82]

kof98.xml

Code: Select all

  <cheat desc="Hit Anywhere Both Players">
    <script state="run">
      <action>maincpu.mw@003B04=6002</action>
    </script>
    <script state="off">
      <action>maincpu.mw@003B04=6600</action>
    </script>
  </cheat>

[Pugsy]

Thanks, added

[orescify]

Code: Select all

  <cheat desc="No Background Music">
    <script state="on">
      <action>audiocpu.rw@114D=1803</action>
      <action>audiocpu.pb@FD89=00</action>
    </script>
    <script state="off">
      <action>audiocpu.rw@114D=CD26</action>
    </script>
  </cheat>
  
  <cheat desc="P1 Character Controls">
    <parameter>
      <item value="0x00">Player</item>
      <item value="0x80">CPU</item>
    </parameter>
    <script state="run">
      <action>maincpu.pb@108270=param|(maincpu.pb@108270 BAND ~80)</action>
    </script>
  </cheat>
  
  <cheat desc="P2 Character Controls">
    <parameter>
      <item value="0x00">Player</item>
      <item value="0x80">CPU</item>
    </parameter>
    <script state="run">
      <action>maincpu.pb@108470=param|(maincpu.pb@108470 BAND ~80)</action>
    </script>
  </cheat>

[orescify]

Thanks, I've added the Select Control cheats but not the "No Background Music" changes...

=1803 just doesn't look right....you sure you didn't mean = 0318.

audiocpu==z80==little endian

so byte order swaps.

Also the off value of CD26 are not the original contents of 114D.

Generally I always use the temp method of restoring the ROM address, as it's got many benefits:

1. You don't have to waste time taking a note of the original contents and risk getting it wrong.

2. If the ROM changes because the set changes the OFF value is also wrong. So if you find that a ROM invincibility for instance suddenly causes the game to crash because the ROM has changed then turning it OFF and resetting will either cause the ROM check to fail or the game may still crash. Using a temp variable write will ensure this doesn't happen

3. Similar to 2, it makes it quick to test clones with a parent/clones cheats and not risking the same issues with crashing or failing ROM tests.

In fact the only time I'd say to use an OFF value is when the program code is in RAM to avoid the possible issue of the cheat being enabled before the program code has been set....and then it really should have a condition to check the RAM contains either the original value (run) or the poked value(off) unless there is a valid reason not to.

Code: Select all

  <cheat desc="No Background Music">
    <script state="on">
      <action>audiocpu.rw@114D=1803</action>
      <action>audiocpu.pb@FD89=00</action>
    </script>
    <script state="off">
      <action>audiocpu.rw@114D=CD26</action>
    </script>
  </cheat>

[orescify]

Thanks for the explanation. I'll look into it another time.